Add configuration option to enable HTTP/1.0 support#1484
Merged
Conversation
added 2 commits
April 30, 2019 15:41
|
Thanks so much and sorry for dropping the ball <3 |
added 2 commits
May 1, 2019 10:09
Member
|
Looks good, thank you! I would ask you to add automated tests for it, but, uh, I'm not sure how to do HTTP/1.0 in our tests so we'll figure it out here. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Envoy supports HTTP/1.0 (https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/core/protocol.proto#envoy-api-msg-core-http1protocoloptions).
This PR exposes a configuration option via Ambassador module to enable/disable support.
Testing
With enable_http10 not set or set to false:
With enable_http10 set to true:
Todos